fix(bot): fix Telegram channel init crash and empty content for Claude#421
Open
ponsde wants to merge 3 commits intovolcengine:mainfrom
Open
fix(bot): fix Telegram channel init crash and empty content for Claude#421ponsde wants to merge 3 commits intovolcengine:mainfrom
ponsde wants to merge 3 commits intovolcengine:mainfrom
Conversation
qin-ctx
reviewed
Mar 5, 2026
bot/vikingbot/channels/telegram.py
Outdated
| groq_api_key: str = "", | ||
| ): | ||
| super().__init__(config, bus, **kwargs) | ||
| super().__init__(config, bus) |
Collaborator
There was a problem hiding this comment.
[Suggestion] workspace_path 未传递给 BaseChannel.__init__，导致 self.workspace_path 始终为 None，媒体文件会下载到 ~/.vikingbot/media 回退路径而非 workspace 目录。
这是预先存在的问题（原代码因 NameError 根本无法运行），但既然 TelegramChannel 现在可以正常工作了，建议一并修复：
- 在
__init__中添加workspace_path参数：
def __init__(
self,
config: TelegramChannelConfig,
bus: MessageBus,
groq_api_key: str = "",
workspace_path: Path | None = None,
):
super().__init__(config, bus, workspace_path)- 在
manager.py实例化时传递workspace_path：
channel = TelegramChannel(
channel_config,
self.bus,
groq_api_key=additional_deps.get("groq_api_key"),
workspace_path=workspace_path,
)
Contributor
Author
Collaborator
TelegramChannel.__init__ references **kwargs in super().__init__() call, but kwargs is not in the method signature. This causes a NameError when the Telegram channel is instantiated, making it completely unusable. Also fixes the type hint from undefined TelegramConfig to the correct TelegramChannelConfig which is already imported.
…bility
When the LLM responds with only tool_calls and no text, content is None.
The expression `content or ""` produces an empty string, which Claude's
API rejects with 400 Bad Request ("text content blocks must be non-empty").
Only include the content field when it is non-empty.
Add workspace_path parameter to TelegramChannel.__init__ and forward to BaseChannel, consistent with all other channel types. Fix ruff format issues in context.py and manager.py. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ponsde
force-pushed
the
fix/telegram-init-and-empty-content
branch
from
9bcd4d6 to
297e33a
Compare
Contributor
Author
|
@qin-ctx 已 rebase 解决冲突，辛苦 review，没注意 main 更新了这么多。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two bugs that prevent Telegram channel and Claude models from working correctly in vikingbot:
TelegramChannel.init NameError (
channels/telegram.py): Thesuper().__init__()call references**kwargs, butkwargsis not defined in the method signature. This causes an immediateNameErrorwhen the Telegram channel is instantiated, making it completely unusable. Also fixes the type hint from undefinedTelegramConfigto the already-importedTelegramChannelConfig.Empty content block rejected by Claude (
agent/context.py): When the LLM responds with onlytool_callsand no text,contentisNone. The expressioncontent or ""produces an empty string"", which Claude/Anthropic API rejects with400 Bad Request("text content blocks must be non-empty"). Fixed by only including thecontentfield when it is non-empty.Type of Change
Testing
Checklist